Unify and remove #show functionality from middeware controllers. #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
middeware_show_cleanup2
branch
from
10f7e34 to
dcceac4
Compare
|
Checked commit martinpovolny@dcceac4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
ping @mzazrivec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GenericShowMixin for #show functionality.
Also removed the removal of Topology breadrumb. Breadcrumbs are not supposed to create a hiareachy but rather history. So it makes no sense to remove the topology link from the breadcumbs.
Besides this unifies the breadcrumb behavior and should we decide that we don't want the topology link in the breadcrumbs we would want that for all the controller not just middleware.
Opening a 2nd PR to make travis behave.
Original PR: #518